Skip to content

fix(sorting): Respect sorting direction set to none when set through sortingExpressions #16342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dkamburov merged 5 commits into from
Oct 22, 2025
Merged

fix(sorting): Respect sorting direction set to none when set through sortingExpressions #16342

dkamburov merged 5 commits into from
Oct 22, 2025

Conversation

@mddragnev
Copy link
Member

@mddragnev mddragnev commented Oct 21, 2025 •
edited
Loading

Internal task: 39090

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@MarielaTihova
Copy link
Contributor

MarielaTihova commented Oct 21, 2025

Arrow up showing on grid, hgrid, treeGrid.

  • It is NOT coloured as it is usually for ASC sorting
  • Data in column is NOT actually sorted
  • BUT there is this indicator of a sorted ASC column. Attached images below:

Only 1 sorted column with sorting direction None
image

One column with sorting direction None + 1 column sorted DESC
image

@mddragnev
Copy link
Member Author

mddragnev commented Oct 22, 2025 •
edited
Loading

Arrow up showing on grid, hgrid, treeGrid.

  • It is NOT coloured as it is usually for ASC sorting
  • Data in column is NOT actually sorted
  • BUT there is this indicator of a sorted ASC column. Attached images below:

Only 1 sorted column with sorting direction None image

One column with sorting direction None + 1 column sorted DESC image

@MarielaTihova This is something that is reproducible in master as well. Probably, this is a UI decision when setting SortingDirection.None so that the user have an idea that some kind of sorting is applied.

@MarielaTihova MarielaTihova added ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification labels Oct 22, 2025
@dkamburov dkamburov merged commit 7b9c095 into master Oct 22, 2025
6 checks passed
@dkamburov dkamburov deleted the mdragnev/handle-sorting-none-master branch October 22, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rkaraivanov rkaraivanov rkaraivanov approved these changes

@MayaKirova MayaKirova Awaiting requested review from MayaKirova

Assignees

@dkamburov dkamburov

@MarielaTihova MarielaTihova

Labels

20.2.x grid: pivot grid: sorting ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mddragnev @MarielaTihova @rkaraivanov @dkamburov